From 5851c2d36faa54859b4de817a76151ac193caf53 Mon Sep 17 00:00:00 2001 From: Scott Lahteine Date: Thu, 31 Aug 2017 11:44:43 -0500 Subject: [PATCH] MAX7219 followup (#7564) * Add MAX7219_DEBUG to Travis CI testing * Tweak config and use standard pin naming for MAX7219_DEBUG * MAX7219: Apply coding standards, use macros, etc. * Make code work... --- .travis.yml | 2 +- Marlin/Configuration_adv.h | 28 ++ Marlin/Max7219_Debug_LEDs.cpp | 274 +++++++----------- Marlin/Max7219_Debug_LEDs.h | 69 ++--- .../AlephObjects/TAZ4/Configuration_adv.h | 38 +-- .../Anet/A6/Configuration_adv.h | 38 +-- .../Anet/A8/Configuration_adv.h | 38 +-- .../BQ/Hephestos/Configuration_adv.h | 38 +-- .../BQ/Hephestos_2/Configuration_adv.h | 38 +-- .../BQ/WITBOX/Configuration_adv.h | 38 +-- .../Cartesio/Configuration_adv.h | 38 +-- .../Felix/Configuration_adv.h | 38 +-- .../Folger Tech/i3-2020/Configuration_adv.h | 38 +-- .../Infitary/i3-M508/Configuration_adv.h | 38 +-- .../Malyan/M150/Configuration_adv.h | 38 +-- .../RigidBot/Configuration_adv.h | 38 +-- .../SCARA/Configuration_adv.h | 38 +-- .../Sanguinololu/Configuration_adv.h | 38 +-- .../TinyBoy2/Configuration_adv.h | 38 +-- .../Velleman/K8200/Configuration_adv.h | 38 +-- .../Velleman/K8400/Configuration_adv.h | 38 +-- .../FLSUN/auto_calibrate/Configuration_adv.h | 38 +-- .../FLSUN/kossel_mini/Configuration_adv.h | 38 +-- .../delta/generic/Configuration_adv.h | 38 +-- .../delta/kossel_mini/Configuration_adv.h | 38 +-- .../delta/kossel_pro/Configuration_adv.h | 38 +-- .../delta/kossel_xl/Configuration_adv.h | 38 +-- .../gCreate/gMax1.5+/Configuration_adv.h | 37 +-- .../makibox/Configuration_adv.h | 38 +-- .../tvrrug/Round2/Configuration_adv.h | 38 +-- .../wt150/Configuration_adv.h | 38 +-- 31 files changed, 717 insertions(+), 681 deletions(-) diff --git a/.travis.yml b/.travis.yml index bc22a9cb2..c96c1a89f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -90,7 +90,7 @@ script: - opt_enable REPRAP_DISCOUNT_SMART_CONTROLLER SDSUPPORT EEPROM_SETTINGS - opt_enable BLINKM PCA9632 RGB_LED NEOPIXEL_RGBW_LED - opt_enable AUTO_BED_LEVELING_LINEAR Z_MIN_PROBE_REPEATABILITY_TEST DEBUG_LEVELING_FEATURE - - opt_enable_adv FWRETRACT + - opt_enable_adv FWRETRACT MAX7219_DEBUG - opt_set ABL_GRID_POINTS_X 16 - opt_set ABL_GRID_POINTS_Y 16 - opt_set_adv FANMUX0_PIN 53 diff --git a/Marlin/Configuration_adv.h b/Marlin/Configuration_adv.h index beb77165c..03f1090b7 100644 --- a/Marlin/Configuration_adv.h +++ b/Marlin/Configuration_adv.h @@ -1382,4 +1382,32 @@ #endif // I2C_POSITION_ENCODERS +/** + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ +//#define MAX7219_DEBUG +#if ENABLED(MAX7219_DEBUG) + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM + + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! + */ + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row + + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. +#endif + #endif // CONFIGURATION_ADV_H diff --git a/Marlin/Max7219_Debug_LEDs.cpp b/Marlin/Max7219_Debug_LEDs.cpp index a5aa3e50d..d6110053f 100644 --- a/Marlin/Max7219_Debug_LEDs.cpp +++ b/Marlin/Max7219_Debug_LEDs.cpp @@ -21,199 +21,160 @@ */ /** - * This module is normally not enabled. It can be enabled to facilitate - * the display of extra debug information during code development. - * It assumes the existance of a Max7219 LED Matrix. A suitable - * device can be obtained on eBay similar to this: http://www.ebay.com/itm/191781645249 - * for under $2.00 including shipping. + * This module is off by default, but can be enabled to facilitate the display of + * extra debug information during code development. It assumes the existence of a + * Max7219 LED Matrix. A suitable device can be obtained on eBay similar to this: + * http://www.ebay.com/itm/191781645249 for under $2.00 including shipping. * - * Just connect up +5v and Gnd to give it power. And then 3 wires declared in the - * #define's below. Actual pin assignments can be changed in MAX7219_DEBUG section - * of configuration_adv.h + * Just connect up +5v and GND to give it power, then connect up the pins assigned + * in Configuration_adv.h. For example, on the Re-ARM you could use: * - * #define Max7219_clock 77 - * #define Max7219_data_in 78 - * #define Max7219_load 79 + * #define MAX7219_CLK_PIN 77 + * #define MAX7219_DIN_PIN 78 + * #define MAX7219_LOAD_PIN 79 * - * First call Max7219_init() and then there are a number of support functions available - * to control the LED's in the 8x8 grid. + * Max7219_init() is called automatically at startup, and then there are a number of + * support functions available to control the LEDs in the 8x8 grid. * * void Max7219_init(); * void Max7219_PutByte(uint8_t data); * void Max7219(uint8_t reg, uint8_t data); - * void Max7219_LED_On( int8_t row, int8_t col); - * void Max7219_LED_Off( int8_t row, int8_t col); - * void Max7219_LED_Toggle( int8_t row, int8_t col); - * void Max7219_Clear_Row( int8_t row); - * void Max7219_Clear_Column( int8_t col); + * void Max7219_LED_On(uint8_t row, uint8_t col); + * void Max7219_LED_Off(uint8_t row, uint8_t col); + * void Max7219_LED_Toggle(uint8_t row, uint8_t col); + * void Max7219_Clear_Row(uint8_t row); + * void Max7219_Clear_Column(uint8_t col); + * void Max7219_Set_Row(uint8_t row, uint8_t val); + * void Max7219_Set_Column(uint8_t col, uint8_t val); + * void Max7219_idle_tasks(); */ - -#include "Marlin.h" +#include "MarlinConfig.h" #if ENABLED(MAX7219_DEBUG) + + #include "Marlin.h" #include "planner.h" #include "stepper.h" #include "Max7219_Debug_LEDs.h" - static uint8_t LEDs[8] = {0}; + static uint8_t LEDs[8] = { 0 }; void Max7219_PutByte(uint8_t data) { - uint8_t i = 8; - while(i > 0) { - digitalWrite( Max7219_clock, LOW); // tick - if (data & 0x80) // check bit - digitalWrite(Max7219_data_in,HIGH); // send 1 - else - digitalWrite(Max7219_data_in,LOW); // send 0 - digitalWrite(Max7219_clock, HIGH); // tock - data = data << 0x01; - --i; // move to lesser bit - } + for (uint8_t i = 8; i--;) { + WRITE(MAX7219_CLK_PIN, LOW); // tick + WRITE(MAX7219_DIN_PIN, (data & 0x80) ? HIGH : LOW); // send 1 or 0 based on data bit + WRITE(MAX7219_CLK_PIN, HIGH); // tock + data <<= 1; } - - void Max7219( uint8_t reg, uint8_t data) { - digitalWrite(Max7219_load, LOW); // begin - Max7219_PutByte(reg); // specify register - Max7219_PutByte(data); // put data - digitalWrite(Max7219_load, LOW); // and tell the chip to load the data - digitalWrite(Max7219_load,HIGH); } - void Max7219_LED_On( int8_t row, int8_t col) { - int x_index; - if ( row>=8 || row<0 || col>=8 || col<0) - return; - if ( LEDs[row] & (0x01< 7 || col > 7) return; + if (TEST(LEDs[row], col) == on) return; // if LED is already on/off, leave alone + if (on) SBI(LEDs[row], col); else CBI(LEDs[row], col); + Max7219(8 - row, LEDs[row]); } - void Max7219_LED_Off( int8_t row, int8_t col) { - int x_index; - if ( row>=8 || row<0 || col>=8 || col<0) - return; - if ( !(LEDs[row] & (0x01<=8 || row<0 || col>=8 || col<0) - return; - if ( (LEDs[row] & (0x01< 7 || col > 7) return; + if (TEST(LEDs[row], col)) + Max7219_LED_Off(row, col); else - Max7219_LED_On( row, col); + Max7219_LED_On(row, col); } - void Max7219_Clear_Column( int8_t col) { - int x_index; - if ( col>=8 || col<0 ) - return; + void Max7219_Clear_Column(const uint8_t col) { + if (col > 7) return; LEDs[col] = 0; - x_index = 7-col; - Max7219( x_index+1, LEDs[col] ); + Max7219(8 - col, LEDs[col]); } - void Max7219_Clear_Row( int8_t row) { - int c; - if ( row>=8 || row<0 ) - return; - - for(c=0; c<8; c++) - Max7219_LED_Off( c, row); + void Max7219_Clear_Row(const uint8_t row) { + if (row > 7) return; + for (uint8_t c = 0; c <= 7; c++) + Max7219_LED_Off(c, row); } - void Max7219_Set_Row( int8_t row, uint8_t val) { - int b; - - if ( row<0 || row>7 ) - return; - - if ( val<0 || val>255 ) - return; - - for(b=0; b<8; b++) - if ( val & (0x01 << b) ) - Max7219_LED_On( 7-b, row); + void Max7219_Set_Row(const uint8_t row, const uint8_t val) { + if (row > 7) return; + for (uint8_t b = 0; b <= 7; b++) + if (TEST(val, b)) + Max7219_LED_On(7 - b, row); else - Max7219_LED_Off( 7-b, row); + Max7219_LED_Off(7 - b, row); } - void Max7219_Set_Column( int8_t col, uint8_t val) { - int x_index; - - if ( col>=8 || col<0 ) - return; - - if ( val<0 || val>255 ) - return; - + void Max7219_Set_Column(const uint8_t col, const uint8_t val) { + if (col > 7) return; LEDs[col] = val; - x_index = 7-col; - Max7219( x_index+1, LEDs[col] ); + Max7219(8 - col, LEDs[col]); } - void Max7219_init() { - int i, x, y; + uint8_t i, x, y; - pinMode(Max7219_data_in, OUTPUT); - pinMode(Max7219_clock, OUTPUT); - pinMode(Max7219_load, OUTPUT); + SET_OUTPUT(MAX7219_DIN_PIN); + SET_OUTPUT(MAX7219_CLK_PIN); - digitalWrite(Max7219_load, HIGH); + OUT_WRITE(MAX7219_LOAD_PIN, HIGH); //initiation of the max 7219 Max7219(max7219_reg_scanLimit, 0x07); Max7219(max7219_reg_decodeMode, 0x00); // using an led matrix (not digits) Max7219(max7219_reg_shutdown, 0x01); // not in shutdown mode Max7219(max7219_reg_displayTest, 0x00); // no display test - Max7219(max7219_reg_intensity, 0x01 & 0x0f); // the first 0x0f is the value you can set - // range: 0x00 to 0x0f - for (i=0; i<8; i++) { // empty registers, turn all LEDs off + Max7219(max7219_reg_intensity, 0x01 & 0x0F); // the first 0x0F is the value you can set + // range: 0x00 to 0x0F + for (i = 0; i <= 7; i++) { // empty registers, turn all LEDs off LEDs[i] = 0x00; - Max7219(i+1,0); + Max7219(i + 1, 0); } - for(x=0; x<8; x++) { // Do an austetically pleasing pattern to fully test - for(y=0; y<8; y++) { // the Max7219 module and LED's. First, turn them - Max7219_LED_On( x, y); // all on. + for (x = 0; x <= 7; x++) // Do an aesthetically pleasing pattern to fully test + for (y = 0; y <= 7; y++) { // the Max7219 module and LEDs. First, turn them + Max7219_LED_On(x, y); // all on. delay(3); } - } - for(x=0; x<8; x++) { // Now, turn them all off. - for(y=0; y<8; y++) { - Max7219_LED_Off( x, y); - delay(3); // delay() is OK here. Max7219_init() is only called from - } // setup() and nothing is running yet. - } + + for (x = 0; x <= 7; x++) // Now, turn them all off. + for (y = 0; y <= 7; y++) { + Max7219_LED_Off(x, y); + delay(3); // delay() is OK here. Max7219_init() is only called from + } // setup() and nothing is running yet. delay(150); - for(x=7; x>=0; x--) { // Now, do the same thing from the opposite direction - for(y=0; y<8; y++) { - Max7219_LED_On( x, y); + for (x = 8; x--;) // Now, do the same thing from the opposite direction + for (y = 0; y <= 7; y++) { + Max7219_LED_On(x, y); delay(2); } - } - for(x=7; x>=0; x--) { - for(y=0; y<8; y++) { - Max7219_LED_Off( x, y); + for (x = 8; x--;) + for (y = 0; y <= 7; y++) { + Max7219_LED_Off(x, y); delay(2); } - } - } + } -/* +/** * These are sample debug features to demonstrate the usage of the 8x8 LED Matrix for debug purposes. * There is very little CPU burden added to the system by displaying information within the idle() * task. @@ -223,17 +184,17 @@ * or clear a row is not very significant. */ void Max7219_idle_tasks() { - #ifdef MAX7219_DEBUG_PRINTER_ALIVE - static int debug_cnt=0; + #if ENABLED(MAX7219_DEBUG_PRINTER_ALIVE) + static int debug_cnt = 0; if (debug_cnt++ > 100) { - Max7219_LED_Toggle(7,7); + Max7219_LED_Toggle(7, 7); debug_cnt = 0; } #endif #ifdef MAX7219_DEBUG_STEPPER_HEAD Max7219_Clear_Row(MAX7219_DEBUG_STEPPER_HEAD); - Max7219_Clear_Row(MAX7219_DEBUG_STEPPER_HEAD+1); + Max7219_Clear_Row(MAX7219_DEBUG_STEPPER_HEAD + 1); if ( planner.block_buffer_head < 8) Max7219_LED_On( planner.block_buffer_head, MAX7219_DEBUG_STEPPER_HEAD); else @@ -242,7 +203,7 @@ #ifdef MAX7219_DEBUG_STEPPER_TAIL Max7219_Clear_Row(MAX7219_DEBUG_STEPPER_TAIL); - Max7219_Clear_Row(MAX7219_DEBUG_STEPPER_TAIL+1); + Max7219_Clear_Row(MAX7219_DEBUG_STEPPER_TAIL + 1); if ( planner.block_buffer_tail < 8) Max7219_LED_On( planner.block_buffer_tail, MAX7219_DEBUG_STEPPER_TAIL ); else @@ -250,37 +211,26 @@ #endif #ifdef MAX7219_DEBUG_STEPPER_QUEUE - static int16_t last_depth=0, current_depth; - uint8_t i; - current_depth = planner.block_buffer_head - planner.block_buffer_tail; + static int16_t last_depth = 0; + int16_t current_depth = planner.block_buffer_head - planner.block_buffer_tail; if (current_depth != last_depth) { // usually, no update will be needed. - - if ( current_depth < 0 ) - current_depth += BLOCK_BUFFER_SIZE; - - if ( current_depth >= BLOCK_BUFFER_SIZE ) - current_depth = BLOCK_BUFFER_SIZE; - - if ( current_depth > 16 ) // if the BLOCK_BUFFER_SIZE is greater than 16 two lines - current_depth = 16; // of LED's is enough to see if the buffer is draining - - if ( current_depth < last_depth ) - for(i=current_depth; i<=last_depth; i++) { // clear the highest order LED's - if ( i & 1) - Max7219_LED_Off(i>>1, MAX7219_DEBUG_STEPPER_QUEUE+1); - else - Max7219_LED_Off(i>>1, MAX7219_DEBUG_STEPPER_QUEUE+0); - } + if (current_depth < 0) current_depth += BLOCK_BUFFER_SIZE; + NOMORE(current_depth, BLOCK_BUFFER_SIZE); + NOMORE(current_depth, 16); // if the BLOCK_BUFFER_SIZE is greater than 16, two lines + // of LEDs is enough to see if the buffer is draining + + const uint8_t st = min(current_depth, last_depth), + en = max(current_depth, last_depth); + if (current_depth < last_depth) + for (uint8_t i = st; i <= en; i++) // clear the highest order LEDs + Max7219_LED_Off(i >> 1, MAX7219_DEBUG_STEPPER_QUEUE + (i & 1)); else - for(i=last_depth; i<=current_depth; i++) { // light up the highest order LED's - if ( i & 1) - Max7219_LED_On(i>>1, MAX7219_DEBUG_STEPPER_QUEUE+1); - else - Max7219_LED_On(i>>1, MAX7219_DEBUG_STEPPER_QUEUE+0); - } + for (uint8_t i = st; i <= en; i++) // set the highest order LEDs + Max7219_LED_On(i >> 1, MAX7219_DEBUG_STEPPER_QUEUE + (i & 1)); + last_depth = current_depth; } #endif } -#endif //MAX7219_DEBUG +#endif // MAX7219_DEBUG diff --git a/Marlin/Max7219_Debug_LEDs.h b/Marlin/Max7219_Debug_LEDs.h index d2a502953..71a5124e3 100644 --- a/Marlin/Max7219_Debug_LEDs.h +++ b/Marlin/Max7219_Debug_LEDs.h @@ -21,34 +21,38 @@ */ /** - * This module is normally not enabled and does not generate any code. But it - * can be enabled to facilitate the display of extra debug information during - * code development. It assumes the existance of a Max7219 LED Matrix. You - * can get one on eBay similar to this: http://www.ebay.com/itm/191781645249 - * for under $2.00 including shipping. + * This module is off by default, but can be enabled to facilitate the display of + * extra debug information during code development. It assumes the existence of a + * Max7219 LED Matrix. A suitable device can be obtained on eBay similar to this: + * http://www.ebay.com/itm/191781645249 for under $2.00 including shipping. * - * Just connect up +5v and Gnd to give it power. And then 3 wires declared in the - * #define's below. Actual pin assignments can be changed in MAX7219_DEBUG section - * of configuration_adv.h + * Just connect up +5v and GND to give it power, then connect up the pins assigned + * in Configuration_adv.h. For example, on the Re-ARM you could use: * - * You first call Max7219_init() and then you have 3 support functions available - * to control the LED's in the 8x8 grid. + * #define MAX7219_CLK_PIN 77 + * #define MAX7219_DIN_PIN 78 + * #define MAX7219_LOAD_PIN 79 + * + * Max7219_init() is called automatically at startup, and then there are a number of + * support functions available to control the LEDs in the 8x8 grid. * * void Max7219_init(); * void Max7219_PutByte(uint8_t data); * void Max7219(uint8_t reg, uint8_t data); - * void Max7219_LED_On( int8_t row, int8_t col); - * void Max7219_LED_Off( int8_t row, int8_t col); - * void Max7219_LED_Toggle( int8_t row, int8_t col); - * void Max7219_Clear_Row( int8_t row); - * void Max7219_Clear_Column( int8_t col); - * void Max7219_Set_Row( int8_t row, int8_t val); - * void Max7219_Set_Column( int8_t column, int8_t val); + * void Max7219_LED_Set(uint8_t row, uint8_t col, bool on); + * void Max7219_LED_On(uint8_t row, uint8_t col); + * void Max7219_LED_Off(uint8_t row, uint8_t col); + * void Max7219_LED_Toggle(uint8_t row, uint8_t col); + * void Max7219_Clear_Row(uint8_t row); + * void Max7219_Clear_Column(uint8_t col); + * void Max7219_Set_Row(uint8_t row, uint8_t val); + * void Max7219_Set_Column(uint8_t col, uint8_t val); * void Max7219_idle_tasks(); */ +#ifndef __MAX7219_DEBUG_LEDS_H__ +#define __MAX7219_DEBUG_LEDS_H__ -#if ENABLED(MAX7219_DEBUG) // // define max7219 registers // @@ -62,24 +66,23 @@ #define max7219_reg_digit6 0x07 #define max7219_reg_digit7 0x08 - #define max7219_reg_intensity 0x0a - #define max7219_reg_displayTest 0x0f + #define max7219_reg_intensity 0x0A + #define max7219_reg_displayTest 0x0F #define max7219_reg_decodeMode 0x09 - #define max7219_reg_scanLimit 0x0b - #define max7219_reg_shutdown 0x0c - + #define max7219_reg_scanLimit 0x0B + #define max7219_reg_shutdown 0x0C void Max7219_init(); void Max7219_PutByte(uint8_t data); - void Max7219(uint8_t reg, uint8_t data); - void Max7219_LED_On( int8_t row, int8_t col); - void Max7219_LED_Off( int8_t row, int8_t col); - void Max7219_LED_Toggle( int8_t row, int8_t col); - void Max7219_Clear_Row( int8_t row); - void Max7219_Clear_Column( int8_t col); - void Max7219_Set_Row( int8_t row, uint8_t val); - void Max7219_Set_Column( int8_t col, uint8_t val); + void Max7219(const uint8_t reg, const uint8_t data); + void Max7219_LED_Set(const uint8_t row, const uint8_t col, const bool on); + void Max7219_LED_On(const uint8_t row, const uint8_t col); + void Max7219_LED_Off(const uint8_t row, const uint8_t col); + void Max7219_LED_Toggle(const uint8_t row, const uint8_t col); + void Max7219_Clear_Row(const uint8_t row); + void Max7219_Clear_Column(const uint8_t col); + void Max7219_Set_Row(const uint8_t row, const uint8_t val); + void Max7219_Set_Column(const uint8_t col, const uint8_t val); void Max7219_idle_tasks(); -#endif - +#endif // __MAX7219_DEBUG_LEDS_H__ diff --git a/Marlin/example_configurations/AlephObjects/TAZ4/Configuration_adv.h b/Marlin/example_configurations/AlephObjects/TAZ4/Configuration_adv.h index 71bfc4a69..f2824f171 100644 --- a/Marlin/example_configurations/AlephObjects/TAZ4/Configuration_adv.h +++ b/Marlin/example_configurations/AlephObjects/TAZ4/Configuration_adv.h @@ -1383,29 +1383,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/Anet/A6/Configuration_adv.h b/Marlin/example_configurations/Anet/A6/Configuration_adv.h index e12347eb9..b59c04fdd 100644 --- a/Marlin/example_configurations/Anet/A6/Configuration_adv.h +++ b/Marlin/example_configurations/Anet/A6/Configuration_adv.h @@ -1383,29 +1383,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/Anet/A8/Configuration_adv.h b/Marlin/example_configurations/Anet/A8/Configuration_adv.h index 73dcf7595..3a7dd4e91 100644 --- a/Marlin/example_configurations/Anet/A8/Configuration_adv.h +++ b/Marlin/example_configurations/Anet/A8/Configuration_adv.h @@ -1383,29 +1383,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/BQ/Hephestos/Configuration_adv.h b/Marlin/example_configurations/BQ/Hephestos/Configuration_adv.h index 1157da121..d8fbc7d1e 100644 --- a/Marlin/example_configurations/BQ/Hephestos/Configuration_adv.h +++ b/Marlin/example_configurations/BQ/Hephestos/Configuration_adv.h @@ -1383,29 +1383,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/BQ/Hephestos_2/Configuration_adv.h b/Marlin/example_configurations/BQ/Hephestos_2/Configuration_adv.h index b22e092d1..a133a57fd 100644 --- a/Marlin/example_configurations/BQ/Hephestos_2/Configuration_adv.h +++ b/Marlin/example_configurations/BQ/Hephestos_2/Configuration_adv.h @@ -1383,29 +1383,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/BQ/WITBOX/Configuration_adv.h b/Marlin/example_configurations/BQ/WITBOX/Configuration_adv.h index 1157da121..d8fbc7d1e 100644 --- a/Marlin/example_configurations/BQ/WITBOX/Configuration_adv.h +++ b/Marlin/example_configurations/BQ/WITBOX/Configuration_adv.h @@ -1383,29 +1383,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/Cartesio/Configuration_adv.h b/Marlin/example_configurations/Cartesio/Configuration_adv.h index 928e98935..9d595ce69 100644 --- a/Marlin/example_configurations/Cartesio/Configuration_adv.h +++ b/Marlin/example_configurations/Cartesio/Configuration_adv.h @@ -1383,29 +1383,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/Felix/Configuration_adv.h b/Marlin/example_configurations/Felix/Configuration_adv.h index a16fbf766..e28dd33c1 100644 --- a/Marlin/example_configurations/Felix/Configuration_adv.h +++ b/Marlin/example_configurations/Felix/Configuration_adv.h @@ -1383,29 +1383,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/Folger Tech/i3-2020/Configuration_adv.h b/Marlin/example_configurations/Folger Tech/i3-2020/Configuration_adv.h index e3ce65ad9..b65e4cc9a 100644 --- a/Marlin/example_configurations/Folger Tech/i3-2020/Configuration_adv.h +++ b/Marlin/example_configurations/Folger Tech/i3-2020/Configuration_adv.h @@ -1383,29 +1383,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/Infitary/i3-M508/Configuration_adv.h b/Marlin/example_configurations/Infitary/i3-M508/Configuration_adv.h index e86f802ae..5c6d95de9 100644 --- a/Marlin/example_configurations/Infitary/i3-M508/Configuration_adv.h +++ b/Marlin/example_configurations/Infitary/i3-M508/Configuration_adv.h @@ -1383,29 +1383,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/Malyan/M150/Configuration_adv.h b/Marlin/example_configurations/Malyan/M150/Configuration_adv.h index f29f66217..04a49b872 100644 --- a/Marlin/example_configurations/Malyan/M150/Configuration_adv.h +++ b/Marlin/example_configurations/Malyan/M150/Configuration_adv.h @@ -1383,29 +1383,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/RigidBot/Configuration_adv.h b/Marlin/example_configurations/RigidBot/Configuration_adv.h index b57af74b3..d10c0efd9 100644 --- a/Marlin/example_configurations/RigidBot/Configuration_adv.h +++ b/Marlin/example_configurations/RigidBot/Configuration_adv.h @@ -1383,29 +1383,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/SCARA/Configuration_adv.h b/Marlin/example_configurations/SCARA/Configuration_adv.h index da8e0ae0e..be09da0d9 100644 --- a/Marlin/example_configurations/SCARA/Configuration_adv.h +++ b/Marlin/example_configurations/SCARA/Configuration_adv.h @@ -1383,29 +1383,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/Sanguinololu/Configuration_adv.h b/Marlin/example_configurations/Sanguinololu/Configuration_adv.h index 46384be46..3ec235a22 100644 --- a/Marlin/example_configurations/Sanguinololu/Configuration_adv.h +++ b/Marlin/example_configurations/Sanguinololu/Configuration_adv.h @@ -1372,29 +1372,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/TinyBoy2/Configuration_adv.h b/Marlin/example_configurations/TinyBoy2/Configuration_adv.h index 610c084ce..50d2ed30b 100644 --- a/Marlin/example_configurations/TinyBoy2/Configuration_adv.h +++ b/Marlin/example_configurations/TinyBoy2/Configuration_adv.h @@ -1383,29 +1383,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/Velleman/K8200/Configuration_adv.h b/Marlin/example_configurations/Velleman/K8200/Configuration_adv.h index 6265725f1..b6b062db7 100644 --- a/Marlin/example_configurations/Velleman/K8200/Configuration_adv.h +++ b/Marlin/example_configurations/Velleman/K8200/Configuration_adv.h @@ -1396,29 +1396,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/Velleman/K8400/Configuration_adv.h b/Marlin/example_configurations/Velleman/K8400/Configuration_adv.h index 703300a67..af7cd2347 100644 --- a/Marlin/example_configurations/Velleman/K8400/Configuration_adv.h +++ b/Marlin/example_configurations/Velleman/K8400/Configuration_adv.h @@ -1383,29 +1383,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/delta/FLSUN/auto_calibrate/Configuration_adv.h b/Marlin/example_configurations/delta/FLSUN/auto_calibrate/Configuration_adv.h index 1f21b2f21..dcecbba7f 100644 --- a/Marlin/example_configurations/delta/FLSUN/auto_calibrate/Configuration_adv.h +++ b/Marlin/example_configurations/delta/FLSUN/auto_calibrate/Configuration_adv.h @@ -1385,29 +1385,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/delta/FLSUN/kossel_mini/Configuration_adv.h b/Marlin/example_configurations/delta/FLSUN/kossel_mini/Configuration_adv.h index 4d41b9280..981994c02 100644 --- a/Marlin/example_configurations/delta/FLSUN/kossel_mini/Configuration_adv.h +++ b/Marlin/example_configurations/delta/FLSUN/kossel_mini/Configuration_adv.h @@ -1385,29 +1385,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/delta/generic/Configuration_adv.h b/Marlin/example_configurations/delta/generic/Configuration_adv.h index 4d41b9280..981994c02 100644 --- a/Marlin/example_configurations/delta/generic/Configuration_adv.h +++ b/Marlin/example_configurations/delta/generic/Configuration_adv.h @@ -1385,29 +1385,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/delta/kossel_mini/Configuration_adv.h b/Marlin/example_configurations/delta/kossel_mini/Configuration_adv.h index 4d41b9280..981994c02 100644 --- a/Marlin/example_configurations/delta/kossel_mini/Configuration_adv.h +++ b/Marlin/example_configurations/delta/kossel_mini/Configuration_adv.h @@ -1385,29 +1385,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/delta/kossel_pro/Configuration_adv.h b/Marlin/example_configurations/delta/kossel_pro/Configuration_adv.h index 35836cefa..819979de6 100644 --- a/Marlin/example_configurations/delta/kossel_pro/Configuration_adv.h +++ b/Marlin/example_configurations/delta/kossel_pro/Configuration_adv.h @@ -1390,29 +1390,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/delta/kossel_xl/Configuration_adv.h b/Marlin/example_configurations/delta/kossel_xl/Configuration_adv.h index a7cd5c764..631c15ec9 100644 --- a/Marlin/example_configurations/delta/kossel_xl/Configuration_adv.h +++ b/Marlin/example_configurations/delta/kossel_xl/Configuration_adv.h @@ -1385,29 +1385,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/gCreate/gMax1.5+/Configuration_adv.h b/Marlin/example_configurations/gCreate/gMax1.5+/Configuration_adv.h index 1848bcf50..da3e8cafc 100644 --- a/Marlin/example_configurations/gCreate/gMax1.5+/Configuration_adv.h +++ b/Marlin/example_configurations/gCreate/gMax1.5+/Configuration_adv.h @@ -1383,29 +1383,32 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ #define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/makibox/Configuration_adv.h b/Marlin/example_configurations/makibox/Configuration_adv.h index 2ea7f33e8..848af29ab 100644 --- a/Marlin/example_configurations/makibox/Configuration_adv.h +++ b/Marlin/example_configurations/makibox/Configuration_adv.h @@ -1383,29 +1383,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/tvrrug/Round2/Configuration_adv.h b/Marlin/example_configurations/tvrrug/Round2/Configuration_adv.h index c878d4951..c1cd7f0c7 100644 --- a/Marlin/example_configurations/tvrrug/Round2/Configuration_adv.h +++ b/Marlin/example_configurations/tvrrug/Round2/Configuration_adv.h @@ -1383,29 +1383,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H diff --git a/Marlin/example_configurations/wt150/Configuration_adv.h b/Marlin/example_configurations/wt150/Configuration_adv.h index 0aa8b7ef0..3b915aade 100644 --- a/Marlin/example_configurations/wt150/Configuration_adv.h +++ b/Marlin/example_configurations/wt150/Configuration_adv.h @@ -1383,29 +1383,31 @@ #endif // I2C_POSITION_ENCODERS /** - * Debug LED's using an 8x8 LED Matrix driven by a Max7219 chip. Fully assembled versions are available on - * eBay for under $2.00 (including shipping) and only require 3 signal wires. - * - * Check out auctions similar to this: https://www.ebay.com/sch/i.html?_from=R40&_trksid=m570.l1313&_nkw=332349290049&_sacat=0 - */ - + * MAX7219 Debug Matrix + * + * Add support for a low-cost 8x8 LED Matrix based on the Max7219 chip, which can be used as a status + * display. Requires 3 signal wires. Some useful debug options are included to demonstrate its usage. + * + * Fully assembled MAX7219 boards can be found on the internet for under $2(US). + * For example, see https://www.ebay.com/sch/i.html?_nkw=332349290049 + */ //#define MAX7219_DEBUG #if ENABLED(MAX7219_DEBUG) - #define Max7219_clock 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display - #define Max7219_data_in 57 // 78 on Re-ARM - #define Max7219_load 44 // 79 on Re-ARM + #define MAX7219_CLK_PIN 64 // 77 on Re-ARM // Configuration of the 3 pins to control the display + #define MAX7219_DIN_PIN 57 // 78 on Re-ARM + #define MAX7219_LOAD_PIN 44 // 79 on Re-ARM - /* - * These are sample debug features that can be turned on and configured for your use. - * The developer will need to manage the use of the various LED's in the 8x8 matrix to avoid conflicts. + /** + * Sample debug features + * If you add more debug displays, be careful to avoid conflicts! */ - #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix from idle() routine if firmware is functioning - #define MAX7219_DEBUG_STEPPER_HEAD 3 // Display row position of stepper queue head on this line and the next line of LED matrix - #define MAX7219_DEBUG_STEPPER_TAIL 5 // Display row position of stepper queue tail on this line and the next line of LED matrix + #define MAX7219_DEBUG_PRINTER_ALIVE // Blink corner LED of 8x8 matrix to show that the firmware is functioning + #define MAX7219_DEBUG_STEPPER_HEAD 3 // Show the stepper queue head position on this and the next LED matrix row + #define MAX7219_DEBUG_STEPPER_TAIL 5 // Show the stepper queue tail position on this and the next LED matrix row - #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Display row position of stepper queue depth on this line and the next line of LED matrix - // If you have stuttering on your Delta printer, this option may help you understand how - // various tweaks you make to your configuration are affecting the printer. + #define MAX7219_DEBUG_STEPPER_QUEUE 0 // Show the current stepper queue depth on this and the next LED matrix row + // If you experience stuttering, reboots, etc. this option can reveal how + // tweaks made to the configuration are affecting the printer in real-time. #endif #endif // CONFIGURATION_ADV_H