From 414b92e8123b9163015fb99ec286439275b000e8 Mon Sep 17 00:00:00 2001 From: Dean Camera Date: Sun, 29 Nov 2009 05:19:41 +0000 Subject: [PATCH] Add to the existing CDC Class Driver's CreateStream() function documentation to explicitly state that the created streams are bidirectional. --- Bootloaders/DFU/BootloaderDFU.c | 8 ++------ Bootloaders/DFU/BootloaderDFU.h | 2 +- LUFA/Drivers/USB/Class/Device/CDC.h | 3 ++- LUFA/Drivers/USB/Class/Host/CDC.h | 3 ++- 4 files changed, 7 insertions(+), 9 deletions(-) diff --git a/Bootloaders/DFU/BootloaderDFU.c b/Bootloaders/DFU/BootloaderDFU.c index 71b37ea68d..4184b190ca 100644 --- a/Bootloaders/DFU/BootloaderDFU.c +++ b/Bootloaders/DFU/BootloaderDFU.c @@ -690,11 +690,7 @@ static void ProcessReadCommand(void) uint8_t DataIndexToRead = SentCommand.Data[1]; if (IS_ONEBYTE_COMMAND(SentCommand.Data, 0x00)) // Read bootloader info - { - ResponseByte = BootloaderInfo[DataIndexToRead]; - } + ResponseByte = BootloaderInfo[DataIndexToRead]; else if (IS_ONEBYTE_COMMAND(SentCommand.Data, 0x01)) // Read signature byte - { - ResponseByte = SignatureInfo[DataIndexToRead - 0x30]; - } + ResponseByte = SignatureInfo[DataIndexToRead - 0x30]; } diff --git a/Bootloaders/DFU/BootloaderDFU.h b/Bootloaders/DFU/BootloaderDFU.h index a4eb235d60..c711e43783 100644 --- a/Bootloaders/DFU/BootloaderDFU.h +++ b/Bootloaders/DFU/BootloaderDFU.h @@ -55,7 +55,7 @@ * can protect the AVR's firmware from being dumped from a secured AVR. When false, memory operations are * allowed at any time. */ - #define SECURE_MODE false + #define SECURE_MODE false /** Major bootloader version number. */ #define BOOTLOADER_VERSION_MINOR 2 diff --git a/LUFA/Drivers/USB/Class/Device/CDC.h b/LUFA/Drivers/USB/Class/Device/CDC.h index f7bdee0198..5cd3aaf61f 100644 --- a/LUFA/Drivers/USB/Class/Device/CDC.h +++ b/LUFA/Drivers/USB/Class/Device/CDC.h @@ -212,7 +212,8 @@ void CDC_Device_SendControlLineStateChange(USB_ClassInfo_CDC_Device_t* const CDCInterfaceInfo) ATTR_NON_NULL_PTR_ARG(1); /** Creates a standard characer stream for the given CDC Device instance so that it can be used with all the regular - * functions in the avr-libc library that accept a FILE stream as a destination (e.g. fprintf). + * functions in the avr-libc library that accept a FILE stream as a destination (e.g. fprintf). The created + * stream is bidirectional and can be used for both input and output functions. * * Reading data from this stream is non-blocking, i.e. in most instances, complete strings cannot be read in by a single * fetch, as the endpoint will not be ready at some point in the transmission, aborting the transfer. However, this may diff --git a/LUFA/Drivers/USB/Class/Host/CDC.h b/LUFA/Drivers/USB/Class/Host/CDC.h index d1ad49c27d..03b31d0edd 100644 --- a/LUFA/Drivers/USB/Class/Host/CDC.h +++ b/LUFA/Drivers/USB/Class/Host/CDC.h @@ -215,7 +215,8 @@ uint8_t CDC_Host_ReceiveByte(USB_ClassInfo_CDC_Host_t* const CDCInterfaceInfo) ATTR_NON_NULL_PTR_ARG(1); /** Creates a standard characer stream for the given CDC Device instance so that it can be used with all the regular - * functions in the avr-libc library that accept a FILE stream as a destination (e.g. fprintf). + * functions in the avr-libc library that accept a FILE stream as a destination (e.g. fprintf). The created + * stream is bidirectional and can be used for both input and output functions. * * \note The created stream can be given as stdout if desired to direct the standard output from all functions * to the given CDC interface.