From 72fc4a204de72bfc3b2d62162d2c8ff59dd5803f Mon Sep 17 00:00:00 2001 From: Dean Camera Date: Sun, 14 Oct 2012 20:18:46 +0000 Subject: [PATCH] Clean up unnecessary CPPCheck static analysis suppression comments, force Doxygen and GCC compiler specific macros as being always undefined when performing a static analysis of the code. --- Bootloaders/HID/BootloaderHID.c | 1 + BuildTests/StaticAnalysisTest/makefile | 5 ++++- Demos/DualRole/ClassDriver/MouseHostDevice/MouseHostDevice.h | 2 ++ .../USB/Core/AVR8/Template/Template_Endpoint_Control_R.c | 1 - .../USB/Core/AVR8/Template/Template_Endpoint_Control_W.c | 1 - LUFA/Drivers/USB/Core/AVR8/Template/Template_Endpoint_RW.c | 1 - LUFA/Drivers/USB/Core/AVR8/Template/Template_Pipe_RW.c | 1 - .../USB/Core/UC3/Template/Template_Endpoint_Control_R.c | 1 - .../USB/Core/UC3/Template/Template_Endpoint_Control_W.c | 1 - LUFA/Drivers/USB/Core/UC3/Template/Template_Endpoint_RW.c | 1 - LUFA/Drivers/USB/Core/UC3/Template/Template_Pipe_RW.c | 1 - .../USB/Core/XMEGA/Template/Template_Endpoint_Control_R.c | 1 - .../USB/Core/XMEGA/Template/Template_Endpoint_Control_W.c | 1 - LUFA/Drivers/USB/Core/XMEGA/Template/Template_Endpoint_RW.c | 1 - 14 files changed, 7 insertions(+), 12 deletions(-) diff --git a/Bootloaders/HID/BootloaderHID.c b/Bootloaders/HID/BootloaderHID.c index 5081762aef..29e1f45b6e 100644 --- a/Bootloaders/HID/BootloaderHID.c +++ b/Bootloaders/HID/BootloaderHID.c @@ -59,6 +59,7 @@ void Application_Jump_Check(void) if ((MCUSR & (1 << WDRF)) && (MagicBootKey == MAGIC_BOOT_KEY)) { MagicBootKey = 0; + // cppcheck-suppress constStatement ((void (*)(void))0x0000)(); } diff --git a/BuildTests/StaticAnalysisTest/makefile b/BuildTests/StaticAnalysisTest/makefile index abac69e90b..9aef3f390b 100644 --- a/BuildTests/StaticAnalysisTest/makefile +++ b/BuildTests/StaticAnalysisTest/makefile @@ -18,10 +18,13 @@ CPPCHECK_EXCLUDES := FATFs/ \ CPPCHECK_INCLUDES := $(patsubst %/,%,$(LUFA_PATH))/CodeTemplates/ \ $(patsubst %/,%,$(LUFA_PATH))/../Projects/AVRISP-MKII/ -CPPCHECK_FLAGS := -U TEMPLATE_FUNC_NAME +CPPCHECK_FLAGS := -U TEMPLATE_FUNC_NAME -U __GNUC__ -U __DOXYGEN__ SRC := $(patsubst %/,%,$(LUFA_PATH))/.. +# Build test cannot be run with multiple parallel jobs +.NOTPARALLEL: + all: begin cppcheck end begin: diff --git a/Demos/DualRole/ClassDriver/MouseHostDevice/MouseHostDevice.h b/Demos/DualRole/ClassDriver/MouseHostDevice/MouseHostDevice.h index efc4cc46e8..d3e0563296 100644 --- a/Demos/DualRole/ClassDriver/MouseHostDevice/MouseHostDevice.h +++ b/Demos/DualRole/ClassDriver/MouseHostDevice/MouseHostDevice.h @@ -70,6 +70,8 @@ /* Function Prototypes: */ void SetupHardware(void); + + void EVENT_USB_UIDChange(void); #endif diff --git a/LUFA/Drivers/USB/Core/AVR8/Template/Template_Endpoint_Control_R.c b/LUFA/Drivers/USB/Core/AVR8/Template/Template_Endpoint_Control_R.c index 69b6abe6e8..4942e70358 100644 --- a/LUFA/Drivers/USB/Core/AVR8/Template/Template_Endpoint_Control_R.c +++ b/LUFA/Drivers/USB/Core/AVR8/Template/Template_Endpoint_Control_R.c @@ -30,7 +30,6 @@ #if defined(TEMPLATE_FUNC_NAME) -// cppcheck-suppress unusedFunction uint8_t TEMPLATE_FUNC_NAME (void* const Buffer, uint16_t Length) { diff --git a/LUFA/Drivers/USB/Core/AVR8/Template/Template_Endpoint_Control_W.c b/LUFA/Drivers/USB/Core/AVR8/Template/Template_Endpoint_Control_W.c index e27cf884ef..a37605c012 100644 --- a/LUFA/Drivers/USB/Core/AVR8/Template/Template_Endpoint_Control_W.c +++ b/LUFA/Drivers/USB/Core/AVR8/Template/Template_Endpoint_Control_W.c @@ -30,7 +30,6 @@ #if defined(TEMPLATE_FUNC_NAME) -// cppcheck-suppress unusedFunction uint8_t TEMPLATE_FUNC_NAME (const void* const Buffer, uint16_t Length) { diff --git a/LUFA/Drivers/USB/Core/AVR8/Template/Template_Endpoint_RW.c b/LUFA/Drivers/USB/Core/AVR8/Template/Template_Endpoint_RW.c index 3766babd31..b82d3926b6 100644 --- a/LUFA/Drivers/USB/Core/AVR8/Template/Template_Endpoint_RW.c +++ b/LUFA/Drivers/USB/Core/AVR8/Template/Template_Endpoint_RW.c @@ -30,7 +30,6 @@ #if defined(TEMPLATE_FUNC_NAME) -// cppcheck-suppress unusedFunction uint8_t TEMPLATE_FUNC_NAME (TEMPLATE_BUFFER_TYPE const Buffer, uint16_t Length, uint16_t* const BytesProcessed) diff --git a/LUFA/Drivers/USB/Core/AVR8/Template/Template_Pipe_RW.c b/LUFA/Drivers/USB/Core/AVR8/Template/Template_Pipe_RW.c index 8b63939d7b..6e4250fc6a 100644 --- a/LUFA/Drivers/USB/Core/AVR8/Template/Template_Pipe_RW.c +++ b/LUFA/Drivers/USB/Core/AVR8/Template/Template_Pipe_RW.c @@ -30,7 +30,6 @@ #if defined(TEMPLATE_FUNC_NAME) -// cppcheck-suppress unusedFunction uint8_t TEMPLATE_FUNC_NAME (TEMPLATE_BUFFER_TYPE const Buffer, uint16_t Length, uint16_t* const BytesProcessed) diff --git a/LUFA/Drivers/USB/Core/UC3/Template/Template_Endpoint_Control_R.c b/LUFA/Drivers/USB/Core/UC3/Template/Template_Endpoint_Control_R.c index 69b6abe6e8..4942e70358 100644 --- a/LUFA/Drivers/USB/Core/UC3/Template/Template_Endpoint_Control_R.c +++ b/LUFA/Drivers/USB/Core/UC3/Template/Template_Endpoint_Control_R.c @@ -30,7 +30,6 @@ #if defined(TEMPLATE_FUNC_NAME) -// cppcheck-suppress unusedFunction uint8_t TEMPLATE_FUNC_NAME (void* const Buffer, uint16_t Length) { diff --git a/LUFA/Drivers/USB/Core/UC3/Template/Template_Endpoint_Control_W.c b/LUFA/Drivers/USB/Core/UC3/Template/Template_Endpoint_Control_W.c index e27cf884ef..a37605c012 100644 --- a/LUFA/Drivers/USB/Core/UC3/Template/Template_Endpoint_Control_W.c +++ b/LUFA/Drivers/USB/Core/UC3/Template/Template_Endpoint_Control_W.c @@ -30,7 +30,6 @@ #if defined(TEMPLATE_FUNC_NAME) -// cppcheck-suppress unusedFunction uint8_t TEMPLATE_FUNC_NAME (const void* const Buffer, uint16_t Length) { diff --git a/LUFA/Drivers/USB/Core/UC3/Template/Template_Endpoint_RW.c b/LUFA/Drivers/USB/Core/UC3/Template/Template_Endpoint_RW.c index 3766babd31..b82d3926b6 100644 --- a/LUFA/Drivers/USB/Core/UC3/Template/Template_Endpoint_RW.c +++ b/LUFA/Drivers/USB/Core/UC3/Template/Template_Endpoint_RW.c @@ -30,7 +30,6 @@ #if defined(TEMPLATE_FUNC_NAME) -// cppcheck-suppress unusedFunction uint8_t TEMPLATE_FUNC_NAME (TEMPLATE_BUFFER_TYPE const Buffer, uint16_t Length, uint16_t* const BytesProcessed) diff --git a/LUFA/Drivers/USB/Core/UC3/Template/Template_Pipe_RW.c b/LUFA/Drivers/USB/Core/UC3/Template/Template_Pipe_RW.c index 8b63939d7b..6e4250fc6a 100644 --- a/LUFA/Drivers/USB/Core/UC3/Template/Template_Pipe_RW.c +++ b/LUFA/Drivers/USB/Core/UC3/Template/Template_Pipe_RW.c @@ -30,7 +30,6 @@ #if defined(TEMPLATE_FUNC_NAME) -// cppcheck-suppress unusedFunction uint8_t TEMPLATE_FUNC_NAME (TEMPLATE_BUFFER_TYPE const Buffer, uint16_t Length, uint16_t* const BytesProcessed) diff --git a/LUFA/Drivers/USB/Core/XMEGA/Template/Template_Endpoint_Control_R.c b/LUFA/Drivers/USB/Core/XMEGA/Template/Template_Endpoint_Control_R.c index cbc1d46afa..541cacbc57 100644 --- a/LUFA/Drivers/USB/Core/XMEGA/Template/Template_Endpoint_Control_R.c +++ b/LUFA/Drivers/USB/Core/XMEGA/Template/Template_Endpoint_Control_R.c @@ -30,7 +30,6 @@ #if defined(TEMPLATE_FUNC_NAME) -// cppcheck-suppress unusedFunction uint8_t TEMPLATE_FUNC_NAME (void* const Buffer, uint16_t Length) { diff --git a/LUFA/Drivers/USB/Core/XMEGA/Template/Template_Endpoint_Control_W.c b/LUFA/Drivers/USB/Core/XMEGA/Template/Template_Endpoint_Control_W.c index fbc9b5bd38..79240a81d2 100644 --- a/LUFA/Drivers/USB/Core/XMEGA/Template/Template_Endpoint_Control_W.c +++ b/LUFA/Drivers/USB/Core/XMEGA/Template/Template_Endpoint_Control_W.c @@ -30,7 +30,6 @@ #if defined(TEMPLATE_FUNC_NAME) -// cppcheck-suppress unusedFunction uint8_t TEMPLATE_FUNC_NAME (const void* const Buffer, uint16_t Length) { diff --git a/LUFA/Drivers/USB/Core/XMEGA/Template/Template_Endpoint_RW.c b/LUFA/Drivers/USB/Core/XMEGA/Template/Template_Endpoint_RW.c index 3766babd31..b82d3926b6 100644 --- a/LUFA/Drivers/USB/Core/XMEGA/Template/Template_Endpoint_RW.c +++ b/LUFA/Drivers/USB/Core/XMEGA/Template/Template_Endpoint_RW.c @@ -30,7 +30,6 @@ #if defined(TEMPLATE_FUNC_NAME) -// cppcheck-suppress unusedFunction uint8_t TEMPLATE_FUNC_NAME (TEMPLATE_BUFFER_TYPE const Buffer, uint16_t Length, uint16_t* const BytesProcessed)