You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Victor Julien f9840b513d version: release 5.0.1 3 days ago
.github github-ci: in a dist build, check that --frozen is being used 2 days ago
benches Initial add of the files. 10 years ago
contrib tile: remove files 9 months ago
doc doc/commandline: -i option is useable several times 5 days ago
ebpf ebpf: make sure 'make dist' include eBPF files 2 months ago
etc config: install classification.config (and ref) to $datadir 2 months ago
lua lua output: Update example script to match style of user doc examples 1 year ago
m4 prelude: update URL 3 years ago
python python: fixes for installing from path with spaces 2 months ago
qa travis: remove cocci and macos builds 1 week ago
rules http: sets compression bomb limit 2 months ago
rust smb1: allow empty trans records 6 days ago
scripts jansson: remove HAVE_LIBJANSSON guards 2 months ago
src detect/asn1: fix offset bounds checking 2 days ago
suricata-update python: fixes for installing from path with spaces 2 months ago
.gitignore qa: generate struct-flags.cocci at each run 1 week ago
.travis.yml travis: remove cocci and macos builds 1 week ago
COPYING GPL license sync with official gpl-2.0.txt 4 years ago
ChangeLog changelog: update for 5.0.1 2 days ago
LICENSE GPL license sync with official gpl-2.0.txt 4 years ago
Makefile.am Makefile: prefix suricata-update error with @ 2 months ago
Makefile.cvs Initial add of the files. 10 years ago
README.md doc: typo fixes 3 months ago
acsite.m4 Added C99 defs/macros to acsite.m4 for CentOS 10 years ago
appveyor.yml ci: updated travis and appveyor for nss/nspr 8 months ago
autogen.sh autogen/rust: remove Cargo.lock 1 year ago
config.rpath Add file needed for some autotools version. 6 years ago
configure.ac version: release 5.0.1 2 days ago
doxygen.cfg doxygen: define UNITTESTS to generate test framework docs 3 years ago
suricata.yaml.in yaml: clarify comment about dump-all-headers 5 days ago
threshold.config docs: replace redmine links and enforce https on oisf urls 1 year ago

README.md

Suricata

Introduction

Suricata is a network IDS, IPS and NSM engine.

Installation

https://redmine.openinfosecfoundation.org/projects/suricata/wiki/Suricata_Installation

User Guide

You can follow the Suricata user guide to get started.

Our deprecated (but still useful) user guide is also available.

Contributing

We’re happily taking patches and other contributions. Please see https://redmine.openinfosecfoundation.org/projects/suricata/wiki/Contributing for how to get started.

Suricata is a complex piece of software dealing with mostly untrusted input. Mishandling this input will have serious consequences:

  • in IPS mode a crash may knock a network offline;
  • in passive mode a compromise of the IDS may lead to loss of critical and confidential data;
  • missed detection may lead to undetected compromise of the network.

In other words, we think the stakes are pretty high, especially since in many common cases the IDS/IPS will be directly reachable by an attacker.

For this reason, we have developed a QA process that is quite extensive. A consequence is that contributing to Suricata can be a somewhat lengthy process.

On a high level, the steps are:

  1. Travis-CI based build & unit testing. This runs automatically when a pull request is made.

  2. Review by devs from the team and community

  3. QA runs

Overview of Suricata’s QA steps

Trusted devs and core team members are able to submit builds to our (semi) public Buildbot instance. It will run a series of build tests and a regression suite to confirm no existing features break.

The final QA run takes a few hours minimally, and is started by Victor. It currently runs:

  • extensive build tests on different OS’, compilers, optimization levels, configure features
  • static code analysis using cppcheck, scan-build
  • runtime code analysis using valgrind, DrMemory, AddressSanitizer, LeakSanitizer
  • regression tests for past bugs
  • output validation of logging
  • unix socket testing
  • pcap based fuzz testing using ASAN and LSAN

Next to these tests, based on the type of code change further tests can be run manually:

  • traffic replay testing (multi-gigabit)
  • large pcap collection processing (multi-terabytes)
  • AFL based fuzz testing (might take multiple days or even weeks)
  • pcap based performance testing
  • live performance testing
  • various other manual tests based on evaluation of the proposed changes

It’s important to realize that almost all of the tests above are used as acceptance tests. If something fails, it’s up to you to address this in your code.

One step of the QA is currently run post-merge. We submit builds to the Coverity Scan program. Due to limitations of this (free) service, we can submit once a day max. Of course it can happen that after the merge the community will find issues. For both cases we request you to help address the issues as they may come up.

FAQ

Q: Will you accept my PR?

A: That depends on a number of things, including the code quality. With new features it also depends on whether the team and/or the community think the feature is useful, how much it affects other code and features, the risk of performance regressions, etc.

Q: When will my PR be merged?

A: It depends, if it’s a major feature or considered a high risk change, it will probably go into the next major version.

Q: Why was my PR closed?

A: As documented in the Suricata Github workflow here https://redmine.openinfosecfoundation.org/projects/suricata/wiki/Github_work_flow, we expect a new pull request for every change.

Normally, the team (or community) will give feedback on a pull request after which it is expected to be replaced by an improved PR. So look at the comments. If you disagree with the comments we can still discuss them in the closed PR.

If the PR was closed without comments it’s likely due to QA failure. If the Travis-CI check failed, the PR should be fixed right away. No need for a discussion about it, unless you believe the QA failure is incorrect.

Q: the compiler/code analyser/tool is wrong, what now?

A: To assist in the automation of the QA, we’re not accepting warnings or errors to stay. In some cases this could mean that we add a suppression if the tool supports that (e.g. valgrind, DrMemory). Some warnings can be disabled. In some exceptional cases the only ‘solution’ is to refactor the code to work around a static code checker limitation false positive. While frustrating, we prefer this over leaving warnings in the output. Warnings tend to get ignored and then increase risk of hiding other warnings.

Q: I think your QA test is wrong

A: If you really think it is, we can discuss how to improve it. But don’t come to this conclusion too quickly, more often it’s the code that turns out to be wrong.

Q: do you require signing of a contributor license agreement?

A: Yes, we do this to keep the ownership of Suricata in one hand: the Open Information Security Foundation. See http://suricata-ids.org/about/open-source/ and http://suricata-ids.org/about/contribution-agreement/