Quellcode durchsuchen

char-pty: Print "char device redirected" message to stdout

char_pty_open() prints a "char device redirected to PTY_NAME (label
LABEL)" message to the current monitor or else to stderr.  This is not
an error, so it shouldn't go to stderr.  Print it to stdout instead.

Why is it even printed?  No other ChardevClass::open() prints anything
on success.  It's because you need to know PTY_NAME to actually use
this char device, e.g. like e.g. "socat STDIO,cfmakeraw FILE:PTY_NAME"
to use the monitor's readline interface.  You can get PTY_NAME with
"info chardev" (a.k.a. query-chardev for QMP), but only if you already
have a monitor.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190417190641.26814-15-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
tags/v4.1.0-rc0
Markus Armbruster vor 5 Monaten
Ursprung
Commit
6ade45f2ac
1 geänderte Dateien mit 3 neuen und 2 gelöschten Zeilen
  1. 3
    2
      chardev/char-pty.c

+ 3
- 2
chardev/char-pty.c Datei anzeigen

@@ -28,6 +28,7 @@
#include "io/channel-file.h"
#include "qemu/sockets.h"
#include "qemu/error-report.h"
#include "qemu/qemu-print.h"

#include "chardev/char-io.h"

@@ -211,8 +212,8 @@ static void char_pty_open(Chardev *chr,
qemu_set_nonblock(master_fd);

chr->filename = g_strdup_printf("pty:%s", pty_name);
error_printf("char device redirected to %s (label %s)\n",
pty_name, chr->label);
qemu_printf("char device redirected to %s (label %s)\n",
pty_name, chr->label);

s = PTY_CHARDEV(chr);
s->ioc = QIO_CHANNEL(qio_channel_file_new_fd(master_fd));

Laden…
Abbrechen
Speichern