forksand
/
marlin-lulzbot-laser
1
1
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Reduce code size, fix bug in smart_fill_mesh

Browse Source
master
Scott Lahteine 8 years ago
parent c4e34adcf1
commit 3517154135
1 changed files with 42 additions and 72 deletions
Show Stats Download Patch File Download Diff File

114
Marlin/ubl_G29.cpp
Unescape View File

@ -1545,84 +1545,54 @@
SERIAL_ECHOLNPGM("Done Editing Mesh"); SERIAL_ECHOLNPGM("Done Editing Mesh");
} }
// /**
// The routine provides the 'Smart Fill' capability. It scans from the * 'Smart Fill': Scan from the outward edges of the mesh towards the center.
// outward edges of the mesh towards the center. If it finds an invalid * If an invalid location is found, use the next two points (if valid) to
// location, it uses the next two points (assumming they are valid) to * calculate a 'reasonable' value for the unprobed mesh point.
// calculate a 'reasonable' value for the unprobed mesh point. */
//
void smart_fill_mesh() { bool smart_fill_one(const uint8_t x, const uint8_t y, const int8_t xdir, const int8_t ydir) {
float f, diff; const int8_t x1 = x + xdir, x2 = x1 + xdir,
for (uint8_t x = 0; x < GRID_MAX_POINTS_X; x++) { // Bottom of the mesh looking up y1 = y + ydir, y2 = y1 + ydir;
for (uint8_t y = 0; y < GRID_MAX_POINTS_Y-2; y++) { // A NAN next to a pair of real values?
if (isnan(ubl.z_values[x][y])) { if (isnan(ubl.z_values[x][y]) && !isnan(ubl.z_values[x1][y1]) && !isnan(ubl.z_values[x2][y2])) {
if (isnan(ubl.z_values[x][y+1])) // we only deal with the first NAN next to a block of if (ubl.z_values[x1][y1] < ubl.z_values[x2][y2]) // Angled downward?
continue; // good numbers. we want 2 good numbers to extrapolate off of. ubl.z_values[x][y] = ubl.z_values[x1][y1]; // Use nearest (maybe a little too high.)
if (isnan(ubl.z_values[x][y+2])) else {
continue; const float diff = ubl.z_values[x1][y1] - ubl.z_values[x2][y2]; // Angled upward
if (ubl.z_values[x][y+1] < ubl.z_values[x][y+2]) // The bed is angled down near this edge. So to be safe, we ubl.z_values[x][y] = ubl.z_values[x1][y1] + diff; // Use closest plus difference
ubl.z_values[x][y] = ubl.z_values[x][y+1]; // use the closest value, which is probably a little too high
else {
diff = ubl.z_values[x][y+1] - ubl.z_values[x][y+2]; // The bed is angled up near this edge. So we will use the closest
ubl.z_values[x][y] = ubl.z_values[x][y+1] + diff; // height and add in the difference between that and the next point
}
break;
}
}
}
for (uint8_t x = 0; x < GRID_MAX_POINTS_X; x++) { // Top of the mesh looking down
for (uint8_t y=GRID_MAX_POINTS_Y-1; y>=1; y--) {
if (isnan(ubl.z_values[x][y])) {
if (isnan(ubl.z_values[x][y-1])) // we only deal with the first NAN next to a block of
continue; // good numbers. we want 2 good numbers to extrapolate off of.
if (isnan(ubl.z_values[x][y-2]))
continue;
if (ubl.z_values[x][y-1] < ubl.z_values[x][y-2]) // The bed is angled down near this edge. So to be safe, we
ubl.z_values[x][y] = ubl.z_values[x][y-1]; // use the closest value, which is probably a little too high
else {
diff = ubl.z_values[x][y-1] - ubl.z_values[x][y-2]; // The bed is angled up near this edge. So we will use the closest
ubl.z_values[x][y] = ubl.z_values[x][y-1] + diff; // height and add in the difference between that and the next point
}
break;
}
} }
return true;
} }
for (uint8_t y = 0; y < GRID_MAX_POINTS_Y; y++) { return false;
for (uint8_t x = 0; x < GRID_MAX_POINTS_X-2; x++) { // Left side of the mesh looking right }
if (isnan(ubl.z_values[x][y])) {
if (isnan(ubl.z_values[x+1][y])) // we only deal with the first NAN next to a block of typedef struct { uint8_t sx, ex, sy, ey; bool yfirst; } smart_fill_info;
continue; // good numbers. we want 2 good numbers to extrapolate off of.
if (isnan(ubl.z_values[x+2][y])) void smart_fill_loop(const smart_fill_info &f) {
continue; if (f.yfirst) {
if (ubl.z_values[x+1][y] < ubl.z_values[x+2][y]) // The bed is angled down near this edge. So to be safe, we const int8_t dir = f.ex > f.sx ? 1 : -1;
ubl.z_values[x][y] = ubl.z_values[x][y+1]; // use the closest value, which is probably a little too high for (uint8_t y = f.sy; y != f.ey; ++y)
else { for (uint8_t x = f.sx; x != f.ex; x += dir)
diff = ubl.z_values[x+1][y] - ubl.z_values[x+2][y]; // The bed is angled up near this edge. So we will use the closest if (smart_fill_one(x, y, dir, 0)) break;
ubl.z_values[x][y] = ubl.z_values[x+1][y] + diff; // height and add in the difference between that and the next point
}
break;
}
}
} }
for (uint8_t y=0; y < GRID_MAX_POINTS_Y; y++) { else {
for (uint8_t x=GRID_MAX_POINTS_X-1; x>=1; x--) { // Right side of the mesh looking left const int8_t dir = f.ey > f.sy ? 1 : -1;
if (isnan(ubl.z_values[x][y])) { for (uint8_t x = f.sx; x != f.ex; ++x)
if (isnan(ubl.z_values[x-1][y])) // we only deal with the first NAN next to a block of for (uint8_t y = f.sy; y != f.ey; y += dir)
continue; // good numbers. we want 2 good numbers to extrapolate off of. if (smart_fill_one(x, y, 0, dir)) break;
if (isnan(ubl.z_values[x-2][y]))
continue;
if (ubl.z_values[x-1][y] < ubl.z_values[x-2][y]) // The bed is angled down near this edge. So to be safe, we
ubl.z_values[x][y] = ubl.z_values[x-1][y]; // use the closest value, which is probably a little too high
else {
diff = ubl.z_values[x-1][y] - ubl.z_values[x-2][y]; // The bed is angled up near this edge. So we will use the closest
ubl.z_values[x][y] = ubl.z_values[x-1][y] + diff; // height and add in the difference between that and the next point
}
break;
}
}
} }
} }
void smart_fill_mesh() {
const smart_fill_info info[] = {
{ 0, GRID_MAX_POINTS_X, 0, GRID_MAX_POINTS_Y - 2, false }, // Bottom of the mesh looking up
{ 0, GRID_MAX_POINTS_X, GRID_MAX_POINTS_Y - 1, 0, false }, // Top of the mesh looking down
{ 0, GRID_MAX_POINTS_X - 2, 0, GRID_MAX_POINTS_Y, true }, // Left side of the mesh looking right
{ GRID_MAX_POINTS_X - 1, 0, 0, GRID_MAX_POINTS_Y, true } // Right side of the mesh looking left
};
for (uint8_t i = 0; i < COUNT(info); ++i) smart_fill_loop(info[i]);
}
void unified_bed_leveling::tilt_mesh_based_on_probed_grid(const bool do_ubl_mesh_map) { void unified_bed_leveling::tilt_mesh_based_on_probed_grid(const bool do_ubl_mesh_map) {
constexpr int16_t x_min = max(MIN_PROBE_X, UBL_MESH_MIN_X), constexpr int16_t x_min = max(MIN_PROBE_X, UBL_MESH_MIN_X),

Write Preview
Loading…
Cancel
Save