Simple fix for selecting which tracked key press to work off of for simple reactive effects (#5745)

pull/5990/head
XScorpion2 6 years ago committed by Drashna Jaelre
parent 59d28fe288
commit 2351739cd9
No known key found for this signature in database
GPG Key ID: 4C4221222CD5F9F0

@ -14,7 +14,8 @@ bool rgb_matrix_solid_reactive(effect_params_t* params) {
// Relies on hue being 8-bit and wrapping // Relies on hue being 8-bit and wrapping
for (uint8_t i = led_min; i < led_max; i++) { for (uint8_t i = led_min; i < led_max; i++) {
uint16_t tick = max_tick; uint16_t tick = max_tick;
for(uint8_t j = 0; j < g_last_hit_tracker.count; j++) { // Reverse search to find most recent key hit
for (int8_t j = g_last_hit_tracker.count - 1; j >= 0; j--) {
if (g_last_hit_tracker.index[j] == i && g_last_hit_tracker.tick[j] < tick) { if (g_last_hit_tracker.index[j] == i && g_last_hit_tracker.tick[j] < tick) {
tick = g_last_hit_tracker.tick[j]; tick = g_last_hit_tracker.tick[j];
break; break;

@ -13,7 +13,8 @@ bool rgb_matrix_solid_reactive_simple(effect_params_t* params) {
uint16_t max_tick = 65535 / rgb_matrix_config.speed; uint16_t max_tick = 65535 / rgb_matrix_config.speed;
for (uint8_t i = led_min; i < led_max; i++) { for (uint8_t i = led_min; i < led_max; i++) {
uint16_t tick = max_tick; uint16_t tick = max_tick;
for(uint8_t j = 0; j < g_last_hit_tracker.count; j++) { // Reverse search to find most recent key hit
for (int8_t j = g_last_hit_tracker.count - 1; j >= 0; j--) {
if (g_last_hit_tracker.index[j] == i && g_last_hit_tracker.tick[j] < tick) { if (g_last_hit_tracker.index[j] == i && g_last_hit_tracker.tick[j] < tick) {
tick = g_last_hit_tracker.tick[j]; tick = g_last_hit_tracker.tick[j];
break; break;

Loading…
Cancel
Save