forksand
/
qmk_firmware
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

temporary Revert "add TODO comment"

Browse Source 
This reverts commit df6165aac9.
pull/5020/head
mtei 6 years ago
parent df6165aac9
commit 634b158f46
2 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File

13
quantum/rgblight.c
Unescape View File

@ -734,7 +734,6 @@ void rgblight_effect_breathing(uint8_t interval) {
static uint16_t last_timer = 0; static uint16_t last_timer = 0;
float val; float val;
//TODO: Integrate timer processing.
if (timer_elapsed(last_timer) < pgm_read_byte(&RGBLED_BREATHING_INTERVALS[interval])) { if (timer_elapsed(last_timer) < pgm_read_byte(&RGBLED_BREATHING_INTERVALS[interval])) {
return; return;
} }
@ -755,7 +754,6 @@ void rgblight_effect_rainbow_mood(uint8_t interval) {
static uint16_t current_hue = 0; static uint16_t current_hue = 0;
static uint16_t last_timer = 0; static uint16_t last_timer = 0;
//TODO: Integrate timer processing.
if (timer_elapsed(last_timer) < pgm_read_byte(&RGBLED_RAINBOW_MOOD_INTERVALS[interval])) { if (timer_elapsed(last_timer) < pgm_read_byte(&RGBLED_RAINBOW_MOOD_INTERVALS[interval])) {
return; return;
} }
@ -778,8 +776,6 @@ void rgblight_effect_rainbow_swirl(uint8_t interval) {
static uint16_t last_timer = 0; static uint16_t last_timer = 0;
uint16_t hue; uint16_t hue;
uint8_t i; uint8_t i;
//TODO: Integrate timer processing.
if (timer_elapsed(last_timer) < pgm_read_byte(&RGBLED_RAINBOW_SWIRL_INTERVALS[interval / 2])) { if (timer_elapsed(last_timer) < pgm_read_byte(&RGBLED_RAINBOW_SWIRL_INTERVALS[interval / 2])) {
return; return;
} }
@ -815,8 +811,6 @@ void rgblight_effect_snake(uint8_t interval) {
if (interval % 2) { if (interval % 2) {
increment = -1; increment = -1;
} }
//TODO: Integrate timer processing.
if (timer_elapsed(last_timer) < pgm_read_byte(&RGBLED_SNAKE_INTERVALS[interval / 2])) { if (timer_elapsed(last_timer) < pgm_read_byte(&RGBLED_SNAKE_INTERVALS[interval / 2])) {
return; return;
} }
@ -854,8 +848,6 @@ const uint8_t RGBLED_KNIGHT_INTERVALS[] PROGMEM = {127, 63, 31};
void rgblight_effect_knight(uint8_t interval) { void rgblight_effect_knight(uint8_t interval) {
static uint16_t last_timer = 0; static uint16_t last_timer = 0;
//TODO: Integrate timer processing.
if (timer_elapsed(last_timer) < pgm_read_byte(&RGBLED_KNIGHT_INTERVALS[interval])) { if (timer_elapsed(last_timer) < pgm_read_byte(&RGBLED_KNIGHT_INTERVALS[interval])) {
return; return;
} }
@ -903,8 +895,6 @@ void rgblight_effect_christmas(void) {
static uint16_t last_timer = 0; static uint16_t last_timer = 0;
uint16_t hue; uint16_t hue;
uint8_t i; uint8_t i;
//TODO: Integrate timer processing.
if (timer_elapsed(last_timer) < RGBLIGHT_EFFECT_CHRISTMAS_INTERVAL) { if (timer_elapsed(last_timer) < RGBLIGHT_EFFECT_CHRISTMAS_INTERVAL) {
return; return;
} }
@ -928,7 +918,6 @@ void rgblight_effect_rgbtest(void) {
static uint8_t maxval = 0; static uint8_t maxval = 0;
uint8_t g; uint8_t r; uint8_t b; uint8_t g; uint8_t r; uint8_t b;
//TODO: Integrate timer processing.
if (timer_elapsed(last_timer) < pgm_read_word(&RGBLED_RGBTEST_INTERVALS[0])) { if (timer_elapsed(last_timer) < pgm_read_word(&RGBLED_RGBTEST_INTERVALS[0])) {
return; return;
} }
@ -954,8 +943,6 @@ void rgblight_effect_rgbtest(void) {
void rgblight_effect_alternating(void){ void rgblight_effect_alternating(void){
static uint16_t last_timer = 0; static uint16_t last_timer = 0;
static uint16_t pos = 0; static uint16_t pos = 0;
//TODO: Integrate timer processing.
if (timer_elapsed(last_timer) < 500) { if (timer_elapsed(last_timer) < 500) {
return; return;
} }

1
quantum/rgblight.h
Unescape View File

@ -162,7 +162,6 @@ typedef union {
typedef struct _rgblight_status_t { typedef struct _rgblight_status_t {
bool timer_enabled; bool timer_enabled;
// TODO: add animation syncronizing // TODO: add animation syncronizing
// (with integrate timer processing.)
} rgblight_status_t; } rgblight_status_t;
#ifdef RGBLIGHT_SPLIT #ifdef RGBLIGHT_SPLIT

Write Preview
Loading…
Cancel
Save