Clean up unnecessary CPPCheck static analysis suppression comments, force Doxygen and GCC compiler specific macros as being always undefined when performing a static analysis of the code.

12 years ago · 72fc4a204d
parent 826a77e90c
commit 72fc4a204d
14 changed files with 7 additions and 12 deletions
--- a/Bootloaders/HID/BootloaderHID.c
+++ b/Bootloaders/HID/BootloaderHID.c
@ -59,6 +59,7 @@ void Application_Jump_Check(void)
 	if ((MCUSR & (1 << WDRF)) && (MagicBootKey == MAGIC_BOOT_KEY))
 	{
 		MagicBootKey = 0;
+		
 		// cppcheck-suppress constStatement
 		((void (*)(void))0x0000)();
 	}
--- a/BuildTests/StaticAnalysisTest/makefile
+++ b/BuildTests/StaticAnalysisTest/makefile
@ -18,10 +18,13 @@ CPPCHECK_EXCLUDES := FATFs/            \
 CPPCHECK_INCLUDES := $(patsubst %/,%,$(LUFA_PATH))/CodeTemplates/               \
                     $(patsubst %/,%,$(LUFA_PATH))/../Projects/AVRISP-MKII/

-CPPCHECK_FLAGS    := -U TEMPLATE_FUNC_NAME
+CPPCHECK_FLAGS    := -U TEMPLATE_FUNC_NAME -U __GNUC__ -U __DOXYGEN__

 SRC               := $(patsubst %/,%,$(LUFA_PATH))/..

+# Build test cannot be run with multiple parallel jobs
+.NOTPARALLEL:
+
 all: begin cppcheck end

 begin:
--- a/Demos/DualRole/ClassDriver/MouseHostDevice/MouseHostDevice.h
+++ b/Demos/DualRole/ClassDriver/MouseHostDevice/MouseHostDevice.h
@ -71,5 +71,7 @@
 	/* Function Prototypes: */
 		void SetupHardware(void);
 		
+		void EVENT_USB_UIDChange(void);
+
 #endif

--- a/LUFA/Drivers/USB/Core/AVR8/Template/Template_Endpoint_Control_R.c
+++ b/LUFA/Drivers/USB/Core/AVR8/Template/Template_Endpoint_Control_R.c
@ -30,7 +30,6 @@

 #if defined(TEMPLATE_FUNC_NAME)

-// cppcheck-suppress unusedFunction
 uint8_t TEMPLATE_FUNC_NAME (void* const Buffer,
                            uint16_t Length)
 {
--- a/LUFA/Drivers/USB/Core/AVR8/Template/Template_Endpoint_Control_W.c
+++ b/LUFA/Drivers/USB/Core/AVR8/Template/Template_Endpoint_Control_W.c
@ -30,7 +30,6 @@

 #if defined(TEMPLATE_FUNC_NAME)

-// cppcheck-suppress unusedFunction
 uint8_t TEMPLATE_FUNC_NAME (const void* const Buffer,
                            uint16_t Length)
 {
--- a/LUFA/Drivers/USB/Core/AVR8/Template/Template_Endpoint_RW.c
+++ b/LUFA/Drivers/USB/Core/AVR8/Template/Template_Endpoint_RW.c
@ -30,7 +30,6 @@

 #if defined(TEMPLATE_FUNC_NAME)

-// cppcheck-suppress unusedFunction
 uint8_t TEMPLATE_FUNC_NAME (TEMPLATE_BUFFER_TYPE const Buffer,
                            uint16_t Length,
                            uint16_t* const BytesProcessed)
--- a/LUFA/Drivers/USB/Core/AVR8/Template/Template_Pipe_RW.c
+++ b/LUFA/Drivers/USB/Core/AVR8/Template/Template_Pipe_RW.c
@ -30,7 +30,6 @@

 #if defined(TEMPLATE_FUNC_NAME)

-// cppcheck-suppress unusedFunction
 uint8_t TEMPLATE_FUNC_NAME (TEMPLATE_BUFFER_TYPE const Buffer,
                            uint16_t Length,
                            uint16_t* const BytesProcessed)
--- a/LUFA/Drivers/USB/Core/UC3/Template/Template_Endpoint_Control_R.c
+++ b/LUFA/Drivers/USB/Core/UC3/Template/Template_Endpoint_Control_R.c
@ -30,7 +30,6 @@

 #if defined(TEMPLATE_FUNC_NAME)

-// cppcheck-suppress unusedFunction
 uint8_t TEMPLATE_FUNC_NAME (void* const Buffer,
                            uint16_t Length)
 {
--- a/LUFA/Drivers/USB/Core/UC3/Template/Template_Endpoint_Control_W.c
+++ b/LUFA/Drivers/USB/Core/UC3/Template/Template_Endpoint_Control_W.c
@ -30,7 +30,6 @@

 #if defined(TEMPLATE_FUNC_NAME)

-// cppcheck-suppress unusedFunction
 uint8_t TEMPLATE_FUNC_NAME (const void* const Buffer,
                            uint16_t Length)
 {
--- a/LUFA/Drivers/USB/Core/UC3/Template/Template_Endpoint_RW.c
+++ b/LUFA/Drivers/USB/Core/UC3/Template/Template_Endpoint_RW.c
@ -30,7 +30,6 @@

 #if defined(TEMPLATE_FUNC_NAME)

-// cppcheck-suppress unusedFunction
 uint8_t TEMPLATE_FUNC_NAME (TEMPLATE_BUFFER_TYPE const Buffer,
                            uint16_t Length,
                            uint16_t* const BytesProcessed)
--- a/LUFA/Drivers/USB/Core/UC3/Template/Template_Pipe_RW.c
+++ b/LUFA/Drivers/USB/Core/UC3/Template/Template_Pipe_RW.c
@ -30,7 +30,6 @@

 #if defined(TEMPLATE_FUNC_NAME)

-// cppcheck-suppress unusedFunction
 uint8_t TEMPLATE_FUNC_NAME (TEMPLATE_BUFFER_TYPE const Buffer,
                            uint16_t Length,
                            uint16_t* const BytesProcessed)
--- a/LUFA/Drivers/USB/Core/XMEGA/Template/Template_Endpoint_Control_R.c
+++ b/LUFA/Drivers/USB/Core/XMEGA/Template/Template_Endpoint_Control_R.c
@ -30,7 +30,6 @@

 #if defined(TEMPLATE_FUNC_NAME)

-// cppcheck-suppress unusedFunction
 uint8_t TEMPLATE_FUNC_NAME (void* const Buffer,
                            uint16_t Length)
 {
--- a/LUFA/Drivers/USB/Core/XMEGA/Template/Template_Endpoint_Control_W.c
+++ b/LUFA/Drivers/USB/Core/XMEGA/Template/Template_Endpoint_Control_W.c
@ -30,7 +30,6 @@

 #if defined(TEMPLATE_FUNC_NAME)

-// cppcheck-suppress unusedFunction
 uint8_t TEMPLATE_FUNC_NAME (const void* const Buffer,
                            uint16_t Length)
 {
--- a/LUFA/Drivers/USB/Core/XMEGA/Template/Template_Endpoint_RW.c
+++ b/LUFA/Drivers/USB/Core/XMEGA/Template/Template_Endpoint_RW.c
@ -30,7 +30,6 @@

 #if defined(TEMPLATE_FUNC_NAME)

-// cppcheck-suppress unusedFunction
 uint8_t TEMPLATE_FUNC_NAME (TEMPLATE_BUFFER_TYPE const Buffer,
                            uint16_t Length,
                            uint16_t* const BytesProcessed)